Move to ubuntu based envoy dockerfiles #8730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
github-actions
bot
added
the
keep pr updated
nfuden
added
the
work in progress
|
Visit the preview URL for this PR (updated for commit d53aca5): https://gloo-edge--pr8730-fix-manual-zlib-gcc-nrwlz6nm.web.app (expires Mon, 09 Oct 2023 21:11:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
ashishb-solo
approved these changes
Oct 2, 2023
ben-taussig-solo
approved these changes
Oct 3, 2023
|
/kick ok so build bot isnt being good |
|
Bulldozer may not be working. Commenting to see if it kicks off |
nfuden
removed
the
work in progress
nfuden
added a commit
that referenced
this pull request
Oct 3, 2023
* Move to ubuntu based envoy dockerfiles * ci: temp remove v for unreleased. Full fix later * Revert "ci: temp remove v for unreleased. Full fix later" This reverts commit 4a66363. * update run-tests.yaml to attempt to pull CI assets * make: Update envoy to released envoy-gloo --------- Co-authored-by: Ben Taussig <[email protected]> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
nfuden
added a commit
that referenced
this pull request
Oct 3, 2023
* Move to ubuntu based envoy dockerfiles (#8730) * Move to ubuntu based envoy dockerfiles * ci: temp remove v for unreleased. Full fix later * Revert "ci: temp remove v for unreleased. Full fix later" This reverts commit 4a66363. * update run-tests.yaml to attempt to pull CI assets * make: Update envoy to released envoy-gloo --------- Co-authored-by: Ben Taussig <[email protected]> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * changelog: move * changelog: move --------- Co-authored-by: Ben Taussig <[email protected]> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move to an ubuntu based envoy image with plans to introduce distroless in 1.16.
This is done to avoid cves in glibc that cannot be fixed with our current alpine setup
https://gitlab.alpinelinux.org/alpine/tsc/-/issues/43#note_306270
sgerrand/alpine-pkg-glibc#207 (comment)
sgerrand/alpine-pkg-glibc#176
Code changes
update docker images for all things with
Context
glibc is sort of eol for alpine. or at least looks like it
Interesting decisions
We chose to do it this way to make normal gateway-proxy -> gateway-proxy-debug be a smaller change.
As we intend to backport this to lts branches we wanted the least potential problems and so opted not to go with only distroless to start.
Testing steps
Gateway-proxy comes up and can handle requests on http and https ports
Gloo pod comes up
Checklist: