ci: Update the intermediate image that gets emitted to no longer rely on alpine due to glibc issues #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on alpine due to glibc issues
|
Issues linked to changelog: |
|
Looks good, though it would be nice to see confirmation of this being consumed + passing CI in Gloo OSS before merging Also, have we been able to scan this to confirm that it is no longer vulnerable to the Glibc issues? |
|
yep scanned a built version of edge and the only issues that were of critical were from the non-in docker pieces that were due to my go version (which I then updated). Scan the images from solo-io/gloo#8730 to see this |
ashishb-solo
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to ubuntu for now.
This can be migrated to distroless in solo-projects if need be in the future but would need to have ubuntu for symbols anyways if we want to follow upstream's behavior.
https://gitlab.alpinelinux.org/alpine/tsc/-/issues/43#note_306270
sgerrand/alpine-pkg-glibc#207 (comment)
sgerrand/alpine-pkg-glibc#176