Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.4] Legacy Promotions: Remove unneeded decorator #6022

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Dec 6, 2024

Backport

This will backport the following commits from main to v4.4:

Questions ?

Please refer to the Backport tool documentation

This is an artifact of the piece-by-piece extraction process I believe.
Since is now done, we can remove this decorator.

(cherry picked from commit 9a74fda)
@github-actions github-actions bot requested a review from a team as a code owner December 6, 2024 13:27
@github-actions github-actions bot added the changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem label Dec 6, 2024
@tvdeyen tvdeyen enabled auto-merge December 6, 2024 13:46
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.45%. Comparing base (bfdf4bb) to head (f9accde).
Report is 6 commits behind head on v4.4.

Additional details and impacted files
@@            Coverage Diff             @@
##             v4.4    #6022      +/-   ##
==========================================
+ Coverage   87.81%   89.45%   +1.63%     
==========================================
  Files         476      782     +306     
  Lines       11658    17993    +6335     
==========================================
+ Hits        10238    16096    +5858     
- Misses       1420     1897     +477     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen disabled auto-merge December 6, 2024 15:08
@tvdeyen tvdeyen merged commit 0f48e0a into v4.4 Dec 6, 2024
14 checks passed
@tvdeyen tvdeyen deleted the backport/v4.4/pr-5955 branch December 6, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants