Legacy Promotions: Remove unneeded decorator #5955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_legacy_promotions
kennyadsl
approved these changes
Nov 30, 2024
tvdeyen
approved these changes
Nov 30, 2024
|
Would you mind to run rubocop --autocorrect? It's unrelated but would make the main branch green. Danke |
|
Nevermind. Already fixed in main. Rebasing. |
This is an artifact of the piece-by-piece extraction process I believe. Since is now done, we can remove this decorator.
tvdeyen
force-pushed
the
remove-unnecessary-decorator
branch
from
dad9993 to
9a74fda
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5955 +/- ##
=======================================
Coverage 89.45% 89.45%
=======================================
Files 782 782
Lines 17997 17997
=======================================
Hits 16100 16100
Misses 1897 1897 ☔ View full report in Codecov by Sentry. |
|
Backport after #6016 |
3 tasks
tvdeyen
added
backport-v4.4
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an artifact of the piece-by-piece extraction process I believe. Since is now done, we can remove this decorator.