Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable admin preview for extensions test apps #5600

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 16, 2024

Summary

The new admin is far from complete and existing
extensions will fail if we test them with the
new default admin that we generate apps with.

It can be enabled by setting ADMIN_PREVIEW=true
in your test env.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

The new admin is far from complete and existing
extensions will fail if we test them with the
new default admin that we generate apps with.

It can be enabled by setting ADMIN_PREVIEW=true
in your test env.
@tvdeyen tvdeyen requested a review from a team as a code owner January 16, 2024 11:40
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Jan 16, 2024
@tvdeyen tvdeyen added backport-v4.3 Backport this pull-request to v4.3 changelog:solidus_core Changes to the solidus_core gem and removed changelog:solidus_core Changes to the solidus_core gem labels Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (be710f3) 88.58% compared to head (27b94a9) 88.57%.

Files Patch % Lines
core/lib/spree/testing_support/common_rake.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5600      +/-   ##
==========================================
- Coverage   88.58%   88.57%   -0.01%     
==========================================
  Files         685      685              
  Lines       16404    16405       +1     
==========================================
  Hits        14531    14531              
- Misses       1873     1874       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 8f228c5 into solidusio:main Jan 17, 2024
15 of 19 checks passed
@tvdeyen tvdeyen deleted the allow-skip-admin-extensions branch January 17, 2024 19:44
Copy link

💚 All backports created successfully

Status Branch Result
v4.3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.3 Backport this pull-request to v4.3 changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants