-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sandbox does not work in v4.3 and main #5598
Comments
You need to run
but even with this the @elia what are the steps to set up a working sandbox locally with |
I can confirm that |
Workaround:
@elia ideally we would have a top level rake task for this or check in the tailwind.css file into the repo, because it wont change often. Then rebuild it via GH actions on push or something (as we do in Alchemy to build our admin bundles) |
you can reduce the number of commands to:
We could also All of that should be better documented once we finalize #5595, sorry about the inconvenience. |
I think this should be automated, and part of the solidus installer (at least). Also, I think this affects all extensions in the ecosystem, as none that I looked at over the past couple of days (and I looked at a few) currently build. Even the ones that should build fail with errors related to |
@elia what do you think about committing the built tailwind css file into the admin repo (and update it on PR merge)? That file won't change much (at least once the admin has been built out). And even in until then it makes to have it updated regularly (not just on gem release). Thoughts? |
In both Solidus 4.3 and in the main branch, the sandbox generates, but cannot be used. I fails with the following error:
Solidus Version:
branches
v4.3
andmain
To Reproduce
Current behavior
Above failure
Expected behavior
I expect the sandbox to work.
Desktop (please complete the following information):
Additional context
I would have loved to provide a fix for a flaky spec with the new admin, but I can't.
The text was updated successfully, but these errors were encountered: