Use spree routing proxy in theme selection partial
#5599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the navigation from a gem that isolates its namespace in such a way that the default route helper is not `spree`, this partial fails to render with an undefined method error. This can easily be fixes by prefixing the route helper with Solidus' routing proxy.
github-actions
bot
added
the
changelog:solidus_backend
|
Please, add a backport to Solidus 4.3 for this one :) |
tvdeyen
approved these changes
Jan 16, 2024
|
Flaky spec will be fixed by #5601 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5599 +/- ##
=======================================
Coverage 88.58% 88.58%
=======================================
Files 685 685
Lines 16404 16404
=======================================
Hits 14531 14531
Misses 1873 1873 ☔ View full report in Codecov by Sentry. |
adammathys
approved these changes
Jan 17, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Jan 18, 2024
This is the same problem and solution as solidusio#5599, just for the theme selection partial that is used when using the current admin (rather than the new one).
3 tasks
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Jan 18, 2024
When using the navigation from a gem that isolates its namespace in such a way that the default route helper is not spree, this partial fails to render with an undefined method error. This can easily be fixed by prefixing the route helper with Solidus' routing proxy. This is the same problem and solution as solidusio#5599, just for the theme selection partial that is used when using the current admin (rather than the new one).
github-actions bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
When using the navigation from a gem that isolates its namespace in such a way that the default route helper is not spree, this partial fails to render with an undefined method error. This can easily be fixed by prefixing the route helper with Solidus' routing proxy. This is the same problem and solution as #5599, just for the theme selection partial that is used when using the current admin (rather than the new one). (cherry picked from commit f4c96a8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using the navigation from a gem that isolates its namespace in such a way that the default route helper is not
spree, this partial fails to render with an undefined method error.This can easily be fixes by prefixing the route helper with Solidus' routing proxy.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: