Theme selection for Solidus Admin: Use spree routing proxy #5604
Conversation
When using the navigation from a gem that isolates its namespace in such a way that the default route helper is not spree, this partial fails to render with an undefined method error. This can easily be fixed by prefixing the route helper with Solidus' routing proxy. This is the same problem and solution as solidusio#5599, just for the theme selection partial that is used when using the current admin (rather than the new one).
github-actions
bot
added
the
changelog:solidus_backend
mamhoff
force-pushed
the
theme-selection-solidus-admin-routing-proxy
branch
from
a980a08 to
f4c96a8
Compare
|
@elia I remember we discussed this at some point. Do you remember why we decided to keep it as is? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5604 +/- ##
=======================================
Coverage 88.57% 88.57%
=======================================
Files 685 685
Lines 16405 16405
=======================================
Hits 14531 14531
Misses 1874 1874 ☔ View full report in Codecov by Sentry. |
I guess that's because that code will run in different contexts, and only for some it will be a problem 😞
I don't remember if we did, I might have a git stash somewhere with exactly this change that got lost hopping between branches and PRs |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Summary
This is the same problem and solution as #5599, just for the theme selection partial that is used when using the current admin (rather than the new one).
Checklist