Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

V1 - Import files to Dev-App #116

Closed
wants to merge 3 commits into from

Conversation

preetham
Copy link
Contributor

@preetham preetham commented Jun 1, 2016

This PR is part of implementation of issue #47 .
Files can now be directly imported into Dev-App. Export of files from Dev-App is WIP.

  • "multer" library is used. It is a middleware which handles multipart/form-data essentially used for uploading files.

  • Single file can be imported at a time.

  • Prevents import of files into "demo" folder.

    Signed-off-by: Kamidi Preetham [email protected]

alert("Error: Upload to demo folder Forbidden!")
}
} else {
console.log("Error: repository not selected");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this console.log

@brunobottazzini
Copy link
Contributor

brunobottazzini commented Jun 3, 2016

The patch looks amazing :)

Just two more things I suggest we to add:

1- I still think that it is a little bit small and the position of the button could be better. See the following image:

screenshot from 2016-06-03 17-32-20

  • The button Select Files should be replaced as Select File since it is only one file we are adding each time.
  • The Select File button should be as in the same level as the label that shows what file is being uploaded

Maybe changing a little bit the html and make it a little bit wider would be great.

2- Imagining that the user might upload a huge file or the user's network is slow. We gotta provide an interface that shows him that we are working on things.
He should not be able to close or upload another file when we are working on the upload. Also, it would amazing if we can put a loading GIF showing that there are working in progress.

So we should do something similar to the importing repository:

screenshot from 2016-06-03 17-50-59

Any doubts on how to make these things, just talk to me anywhere.

Thanks! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants