Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

V2 - Import files to Dev-App #127

Closed
wants to merge 3 commits into from
Closed

V2 - Import files to Dev-App #127

wants to merge 3 commits into from

Conversation

preetham
Copy link
Contributor

Changes from V1:

  • multer.js added to package.json through npm.
  • Added loading GIF which indicates the file is still being imported.
  • File to be uploaded is displayed next to the "Select File" button in Import File dialog.
  • Removed unnecessary console.logs
  • Wider Import File dialog.

brunobottazzini
brunobottazzini reviewed Jun 30, 2016
View reviewed changes
server/routes.js
router.post('/api/file/upload', function(req, res) {
upload(req, res, function(err) {
if (err) {
res.status(400).send("File Upload Failed!");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of just saying failed here try putting something like

res.status(400).send("File Upload Failed reason: " + err);

@preetham preetham closed this Jul 6, 2016
@preetham preetham mentioned this pull request Jul 6, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@preetham @brunobottazzini