This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
Cleanup - old Goblin ELF parser #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
reviewed
Jul 3, 2024
|
Instead of force pushing, try to make a new commit with the new changes in a PR. This facilitates the review. |
LucasSte
approved these changes
Jul 3, 2024
* Removes the dependency "goblin". * Removes the adapter traits. * Inlines the trivial implementations and such that have only one call site. Moves the rest to other files. * Dissolves NewParser. * Removes std::borrow::Cow.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.