Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to the most recent PHP versions #80

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

henriquemoody
Copy link
Contributor

@henriquemoody henriquemoody commented Dec 2, 2024

Hi there!

I've noticed that the library does not run in PHP 8.4, so I add the latest PHP versions and made some fixes, however, it seems like there's quite a lot to change.

  • Are you planning to give support for the most recent PHP versions any time soon?
  • Are you planning on dropping support to old PHP versions?

composer.json Outdated Show resolved Hide resolved
@henriquemoody henriquemoody changed the title Add support for most recent PHP version Add support to most recent PHP version Dec 2, 2024
@henriquemoody henriquemoody changed the title Add support to most recent PHP version Add support to the most recent PHP versions Dec 2, 2024
@coveralls
Copy link

coveralls commented Dec 2, 2024

Coverage Status

coverage: 90.887%. remained the same
when pulling d6948f8 on henriquemoody:php-versions
into 308acfc on sokil:4.0.

@henriquemoody henriquemoody force-pushed the php-versions branch 7 times, most recently from 6c2f023 to 461a471 Compare December 2, 2024 15:41
@henriquemoody henriquemoody marked this pull request as ready for review December 6, 2024 13:56
@henriquemoody henriquemoody force-pushed the php-versions branch 7 times, most recently from 405c14f to 739103d Compare December 6, 2024 14:13
@henriquemoody
Copy link
Contributor Author

I reverted the changes I made, and just added the support for the new versions.

@sokil sokil merged commit 5654656 into sokil:4.0 Dec 11, 2024
12 checks passed
@henriquemoody henriquemoody deleted the php-versions branch December 11, 2024 09:19
@henriquemoody
Copy link
Contributor Author

Hi @sokil! When would you release the patch version?

I'm waiting for it to add support to PHP 8.4 to Respect\Validation

@sokil
Copy link
Owner

sokil commented Dec 11, 2024

Check 4.2.1

Thank you

@henriquemoody
Copy link
Contributor Author

I can't find version 4.2.1, yet, when are you planning on creating it?

@sokil
Copy link
Owner

sokil commented Dec 11, 2024

Sorry, version is on the way to packagist. Please, check.

@henriquemoody
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants