Merge pull request #80 from henriquemoody/php-versions

Add support to the most recent PHP versions
sokil · Dec 11, 2024 · 5654656 · 5654656
2 parents 308acfc + d6948f8
commit 5654656
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml
@@ -19,6 +19,9 @@ jobs:
           - "7.4"
           - "8.0"
           - "8.1"
+          - "8.2"
+          - "8.3"
+          - "8.4"
 
     steps:
     - uses: actions/checkout@v2
@@ -102,4 +105,4 @@ jobs:
         run: composer check-style
 
       - name: Run static analyse
-        run: composer psalm
+        run: composer psalm
diff --git a/src/AbstractDatabase.php b/src/AbstractDatabase.php
@@ -50,8 +50,8 @@ abstract class AbstractDatabase implements \Iterator, \Countable
      * @throws \RuntimeException when base directory not specified and directory can not be located automatically
      */
     public function __construct(
-        string $baseDirectory = null,
-        TranslationDriverInterface $translationDriver = null
+        ?string $baseDirectory = null,
+        ?TranslationDriverInterface $translationDriver = null
     ) {
         if (empty($baseDirectory)) {
             // Require external database in "sokil/php-isocodes-db-*" packages

diff --git a/src/IsoCodesFactory.php b/src/IsoCodesFactory.php
@@ -61,8 +61,8 @@ class IsoCodesFactory
     private $translationDriver;
 
     public function __construct(
-        string $baseDirectory = null,
-        TranslationDriverInterface $translationDriver = null
+        ?string $baseDirectory = null,
+        ?TranslationDriverInterface $translationDriver = null
     ) {
         $this->baseDirectory = $baseDirectory;
         $this->translationDriver = $translationDriver ?? new GettextExtensionDriver();