Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vote and create/update proposals with session key #320

Closed
wants to merge 97 commits into from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented May 6, 2024

Summary

Closes: #319

This PR add the ability to use session key for additional actions:

  • vote
  • create proposal
  • update proposal

How to test

Need to wait for snapshot-labs/snapshot-sequencer#347 to be merged first, or use local branch

New proposal

  1. Try to create a proposal on an offchain space
  2. It should ask to sign a tx to create a session key if not already created
  3. It should create the proposal without asking to sign additional tx

Update proposal

  1. Go to your space setting on v1, and add some voting delay (to create pending proposals)
  2. Go to sx, and create a new proposal
  3. Edit the new proposal
  4. It should update without tx signing

Vote

  1. Vote on an offchain proposal
  2. It should cast the vote without tx signing

To-Do

@wa0x6e wa0x6e changed the base branch from master to add-session-keys May 6, 2024 20:27
Base automatically changed from add-session-keys to master May 29, 2024 09:29
@Sekhmet
Copy link
Member

Sekhmet commented Jul 15, 2024

What is status of this PR? I see that sequencer PR is not merged, but approved. It has lots of merge conflicts currently as well.
If it's still WIP can we turn it into a draft?

@wa0x6e wa0x6e marked this pull request as draft July 15, 2024 14:07
@wa0x6e
Copy link
Contributor Author

wa0x6e commented Jul 15, 2024

Converting to draft. This PR was ready technically at the time, but stalled for security issues on sequencer. Will reopen again when the task will surface again in later cycles

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Jul 25, 2024

Will open a new one again when needed, as this one is too old and has too much merge conflict

@wa0x6e wa0x6e closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: session key to cast a vote and propose
2 participants