Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable alias voting and propose globally #347

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented May 6, 2024

Needed for snapshot-labs/sx-monorepo#320

This PR will enable the already existing voting and proposal creation with alias globally, without checking for space settings

ChaituVR

This comment was marked as resolved.

Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds a bit dangerous because users don't have any option to delete their alias
just in case if user login using a unknown device

Maybe before this could we add a way for users to delete their alias and have an expiry for alias? so that old alias won't be used to cast votes

@wa0x6e
Copy link
Contributor Author

wa0x6e commented May 7, 2024

Sounds a bit dangerous because users don't have any option to delete their alias just in case if user login using a unknown device

Maybe before this could we add a way for users to delete their alias and have an expiry for alias? so that old alias won't be used to cast votes

Yes, ideally, we should have a section in user profile to list all alias, and ideally, have a way to customize which actions can be used with alias

src/ingestor.ts Outdated Show resolved Hide resolved
@wa0x6e wa0x6e requested a review from ChaituVR May 8, 2024 14:32
@ChaituVR
Copy link
Member

waiting for #353

Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants