Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added upload check for targets #125

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Added upload check for targets #125

merged 2 commits into from
Sep 18, 2023

Conversation

dogversioning
Copy link
Contributor

This PR updates the upload --target argument to actually filter the list of files to upload

Checklist

  • Consider if documentation (like in docs/) needs to be updated
  • Consider if tests should be added
  • Run pylint if you're making changes beyond adding studies
  • Update template repo if there are changes to study configuration

mikix
mikix approved these changes Sep 18, 2023
View reviewed changes
cumulus_library/upload.py Outdated Show resolved Hide resolved
tests/test_cli.py
],
]
cli.main(cli_args=args)
assert mock_upload_data.call_count == calls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I might prefer to also see a comparison of the actual paths, to confirm the filtering got the right ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this is lightly contrived, but there is a check now making sure the right path was selected.

@dogversioning dogversioning merged commit 8db3902 into main Sep 18, 2023
3 checks passed
@dogversioning dogversioning deleted the mg/upload_filter branch September 18, 2023 20:19
@dogversioning dogversioning mentioned this pull request Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikix mikix mikix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dogversioning @mikix