Bm browse view #305
Open
Bm browse view #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bm-browse-view
Bianca-Morris
changed the base branch from
main
to
dmichaels-20241119-browse-view
| "to": 89, | ||
| "label": "80-89" | ||
| }, | ||
| { |
There was a problem hiding this comment.
Small note: I think all ages 89 and above will be set to 89, so we may want to have the range be "80-88" and "89 and up" or something similar
There was a problem hiding this comment.
I'll check with Elizabeth; I believe they wanted it to be 90+, but that might have changed.
| // File facets used in production browse ui | ||
| 'access_status', | ||
| 'donors.display_title', | ||
| 'donors.age', |
There was a problem hiding this comment.
The "Donor Age" and "Donor Sex" facets aren't rendering for me. I'm not sure, but embedding
Suggested change
| 'donors.age', | |
| "file_sets.libraries.analytes.samples.sample_sources.donor.age", | |
| "file_sets.libraries.analytes.samples.sample_sources.donor.sex", |
instead of donors.age and donors.sex may work
There was a problem hiding this comment.
Oh interesting. Can you send a screenshot of what that's looking like for you? It's appearing like this on wolf for me:
There was a problem hiding this comment.
For some reason the facet for Donor Age isn't selecting the files, even though they are all from a 47-year-old donor, and for Donor Sex, no value is showing up
dmichaels-harvard
approved these changes
Dec 19, 2024
sarahgonicholson
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
browse.py, addedsample_summary.studies=Production&status=releasedto base query. Removedadditional_facets, since defining those inFile.jsonmetadata.py, addedstatusfacet support to/peek_metadatafile.jsonadded/re-ordered various facets.App.js:scrolledPast460bit of state + class to body to make styling accommodations for larger space above table onBrowseView.context.@atype[0]as a data attribute on body; to make it easier to adjust styling on pages with server render errorsBrowseView.js:BrowseView(Note: may be worth re-addingDetailPaneStateCachein future for performance; need to test with more data to see if it'll be necessary)filteredFiltersmethodBigDropdownBigLinkhere from 4DNBrowseViewControllerWithSelections- right now this is basically a copy ofTableControllerWithSelections. I anticipate this might change enough in the future to justify having it in a separate component - if that day doesn't come, feel free to merge them.BrowseViewonly facets from benchmarkingSlidingSidebarLayoutcomponentSlidingSidebarLayout, similar/types/to add embeds for various fields needed for facets and columns.Base PR:
Required SPC PRs:
Related Trello Ticket:
Screenshots:
