-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bm browse view #263
Open
Bianca-Morris
wants to merge
11
commits into
master
Choose a base branch
from
bm-browse-view
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bm browse view #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Bianca-Morris FYI, I pushed two minor commits to make it work with 4DN. (otherwise, it doesn't render the button styles) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
currentAction
=multiselect
(hideStickyFooter
prop)SelectedItemsController
inSearchView
directly whencurrentAction
=multiselect
(useCustomSelectionController
prop)AboveTableControlsBase
for SMaHTBrowseView
tableRightButtonsSection
toColumnCustomizationButtons
, since they will no longer always be on the right sideColumnCustomizationButtons
(including button child styling, rendering without wrapper div)bytesToLargerUnit
to allow showing only unit or only valueRelated SMaHT PR:
Related Trello Ticket: