Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bm browse view #263

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Bm browse view #263

wants to merge 11 commits into from

Conversation

Bianca-Morris
Copy link
Member

@Bianca-Morris Bianca-Morris commented Dec 17, 2024

Changelog:

  • Add a means of hiding the sticky footer that appears on SearchView when currentAction = multiselect (hideStickyFooter prop)
  • Add a means of bypassing the use of SelectedItemsController in SearchView directly when currentAction = multiselect (useCustomSelectionController prop)
  • Add an alternative layout to AboveTableControlsBase for SMaHT BrowseView table
    • Rename RightButtonsSection to ColumnCustomizationButtons, since they will no longer always be on the right side
    • Additional customization for ColumnCustomizationButtons (including button child styling, rendering without wrapper div)
  • Rework bytesToLargerUnit to allow showing only unit or only value

Related SMaHT PR:

Related Trello Ticket:

@Bianca-Morris Bianca-Morris marked this pull request as ready for review December 18, 2024 19:04
@utku-ozturk
Copy link
Member

@Bianca-Morris FYI, I pushed two minor commits to make it work with 4DN. (otherwise, it doesn't render the button styles)

Screen Shot 2024-12-24 at 13 48 22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants