Skip to content

chore(deps): update pytest requirement from <8.4,>=6.2.5 to >=6.2.5,<8.5 #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update pytest requirement from <8.4,>=6.2.5 to >=6.2.5,<8.5 #1328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements/testing_without_asyncio.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# pip install -r requirements/testing_without_asyncio.txt
pytest>=6.2.5,<8.4 # https://github.com/tornadoweb/tornado/issues/3375
pytest>=6.2.5,<8.5 # https://github.com/tornadoweb/tornado/issues/3375
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Unsure if this version can remain unbound now that the linked issue is closed?

Suggested change
pytest>=6.2.5,<8.5 # https://github.com/tornadoweb/tornado/issues/3375
pytest>=6.2.5,<8.5

Copy link
Contributor

@WilliamBergamin WilliamBergamin Jul 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yess I think we can remove the lower bound requirement, as you mentioned the issue is closed and I think it was for support with python 3.6 but lets keep the upper bound for ease of maintenance

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilliamBergamin Good calls! I found an interesting page on supported versions so opened up another PR to make this change:

🔗 #1333

Copy link
Contributor

@WilliamBergamin WilliamBergamin Jul 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 💯 merge away

pytest-cov>=3,<7
Loading