-
Notifications
You must be signed in to change notification settings - Fork 271
chore(deps): update pytest requirement from <8.4,>=6.2.5 to >=6.2.5,<8.5 #1328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1328 +/- ##
=======================================
Coverage 90.96% 90.96%
=======================================
Files 222 222
Lines 7501 7501
=======================================
Hits 6823 6823
Misses 678 678 ☔ View full report in Codecov by Sentry. |
4c92a7d
to
38e4aaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dependabot LGTM but I am not sure if this should be merged with #1329 🔍
@@ -1,3 +1,3 @@ | |||
# pip install -r requirements/testing_without_asyncio.txt | |||
pytest>=6.2.5,<8.4 # https://github.com/tornadoweb/tornado/issues/3375 | |||
pytest>=6.2.5,<8.5 # https://github.com/tornadoweb/tornado/issues/3375 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Unsure if this version can remain unbound now that the linked issue is closed?
pytest>=6.2.5,<8.5 # https://github.com/tornadoweb/tornado/issues/3375 | |
pytest>=6.2.5,<8.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yess I think we can remove the lower bound requirement, as you mentioned the issue is closed and I think it was for support with python 3.6 but lets keep the upper bound for ease of maintenance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WilliamBergamin Good calls! I found an interesting page on supported versions so opened up another PR to make this change:
🔗 #1333
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet 💯 merge away
5b30e1c
to
8f56632
Compare
Updates the requirements on [pytest](https://github.com/pytest-dev/pytest) to permit the latest version. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@6.2.5...8.4.1) --- updated-dependencies: - dependency-name: pytest dependency-version: 8.4.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
8f56632
to
ead52e8
Compare
We can merge this and deal with #1329 separately |
Updates the requirements on pytest to permit the latest version.
Release notes
Sourced from pytest's releases.
Commits
8d99211
Prepare release version 8.4.15dc5880
docs: update pytest.ini addopts example to use separate -p entries (#13529) (...d0c7ed0
Reintroduce PytestReturnNotNoneWarning (#13495) (#13527)a1b3a78
Fix compatibility with Twisted 25 (#13502) (#13531)4c161ab
pytester: avoid unraisableexception gc collects in inline runs to speed up te...a86ee09
Fix typo in parametrize.rst (#13514) (#13516)1a0581b
Remove outdated warning about faulthandler_timeout on Windows (#13492) (#13493)4e631a7
Merge pull request #13486 from hosmir/fixtypo (#13487)b49745e
fix: support TerminalReporter.isatty being called (#13462) (#13483)cc5ceed
RELEASING: remove pytest mailing list (#13472) (#13473)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)