chore: Default Process Proposal #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidterpay
added
backport/v1.x.x
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #543 +/- ##
==========================================
- Coverage 44.03% 43.91% -0.13%
==========================================
Files 63 63
Lines 2782 2792 +10
==========================================
+ Hits 1225 1226 +1
- Misses 1431 1439 +8
- Partials 126 127 +1 ☔ View full report in Codecov by Sentry. |
aljo242
requested review from
nivasan1,
aljo242 and
Eric-Warehime
as code owners
technicallyty
approved these changes
Jun 24, 2024
tests/app/README.md
Outdated
Comment on lines
34
to
35
| This controls how many transactions can be stored by each lane, how much block space is allocated to each lane, how to extract transacation information such as signers, fees, and more. Each lane should have a separate `LaneConfig` object.` | ||
|
|
There was a problem hiding this comment.
Suggested change
| This controls how many transactions can be stored by each lane, how much block space is allocated to each lane, how to extract transacation information such as signers, fees, and more. Each lane should have a separate `LaneConfig` object.` | |
| This controls how many transactions can be stored by each lane, how much block space is allocated to each lane, how to extract transacation information such as signers, fees, and more. Each lane should have a separate `LaneConfig` object. | |
aljo242
approved these changes
Jun 25, 2024
tests/app/app.go
Outdated
| @@ -262,11 +262,20 @@ func New( | |||
|
|
|||
| // Step 6: Create the proposal handler and set it on the app. Now the application | |||
| // will build and verify proposals using the Block SDK! | |||
| proposalHandler := abci.NewProposalHandler( | |||
| // | |||
| // NOTE: It is generally recommended to use the default proposal handler by constructing | |||
There was a problem hiding this comment.
Suggested change
| // NOTE: It is generally recommended to use the default proposal handler by constructing | |
| // NOTE: It is recommended to use the default proposal handler by constructing |
mergify bot
pushed a commit
that referenced
this pull request
Jun 25, 2024
* init * nits (cherry picked from commit 79d7ef7) # Conflicts: # abci/abci.go
mergify bot
pushed a commit
that referenced
this pull request
Jun 25, 2024
* init * nits (cherry picked from commit 79d7ef7) # Conflicts: # abci/abci.go
This was referenced Jun 25, 2024
davidterpay
added a commit
that referenced
this pull request
Jun 25, 2024
* chore: Default Process Proposal (#543) * init * nits (cherry picked from commit 79d7ef7) # Conflicts: # abci/abci.go * nit test case --------- Co-authored-by: David Terpay <[email protected]> Co-authored-by: David Terpay <[email protected]>
davidterpay
added a commit
that referenced
this pull request
Jun 25, 2024
* chore: Default Process Proposal (#543) * init * nits (cherry picked from commit 79d7ef7) # Conflicts: # abci/abci.go * nit test case --------- Co-authored-by: David Terpay <[email protected]> Co-authored-by: David Terpay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.