Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Default Process Proposal (backport #543) #548

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 25, 2024


This is an automatic backport of pull request #543 done by [Mergify](https://mergify.com).

* init

* nits

(cherry picked from commit 79d7ef7)

# Conflicts:
#	abci/abci.go
@mergify mergify bot added the conflicts label Jun 25, 2024
Copy link
Author

mergify bot commented Jun 25, 2024

Cherry-pick of 79d7ef7 has failed:

On branch mergify/bp/release/v1.x.x/pr-543
Your branch is up to date with 'origin/release/v1.x.x'.

You are currently cherry-picking commit 79d7ef7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   abci/abci_test.go
	modified:   abci/utils_test.go
	modified:   tests/app/README.md
	modified:   tests/app/app.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   abci/abci.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v1.x.x@c65a194). Learn more about missing BASE report.

Files Patch % Lines
abci/abci.go 50.00% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             release/v1.x.x     #548   +/-   ##
=================================================
  Coverage                  ?   49.40%           
=================================================
  Files                     ?       41           
  Lines                     ?     1773           
  Branches                  ?        0           
=================================================
  Hits                      ?      876           
  Misses                    ?      806           
  Partials                  ?       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidterpay davidterpay merged commit 24df187 into release/v1.x.x Jun 25, 2024
11 of 12 checks passed
@davidterpay davidterpay deleted the mergify/bp/release/v1.x.x/pr-543 branch June 25, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant