Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Remove double hashing (backport #517) #518

Merged
merged 1 commit into from
Jun 18, 2024
Merged

perf: Remove double hashing (backport #517) #518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions abci/checktx/mempool_parity_check_tx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,11 @@ func (m MempoolParityCheckTx) CheckTx() CheckTx {
}

isReCheck := req.Type == cmtabci.CheckTxType_Recheck
txInMempool := m.mempl.Contains(tx)

// if the mode is ReCheck and the app's mempool does not contain the given tx, we fail
// immediately, to purge the tx from the comet mempool.
if isReCheck && !m.mempl.Contains(tx) {
if isReCheck && !txInMempool {
m.logger.Debug(
"tx from comet mempool not found in app-side mempool",
"tx", tx,
Expand All @@ -80,7 +81,7 @@ func (m MempoolParityCheckTx) CheckTx() CheckTx {
// the app-side mempool
if isInvalidCheckTxExecution(res) && isReCheck {
// check if the tx exists first
if m.mempl.Contains(tx) {
if txInMempool {
// remove the tx
if err := m.mempl.Remove(tx); err != nil {
m.logger.Debug(
Expand Down
Loading