perf: Remove double hashing (backport #517) #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 2ae5b14)
davidterpay
approved these changes
Jun 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v1.x.x #518 +/- ##
=================================================
Coverage ? 49.31%
=================================================
Files ? 39
Lines ? 1683
Branches ? 0
=================================================
Hits ? 830
Misses ? 762
Partials ? 91 ☔ View full report in Codecov by Sentry. |
|
TYSM for quick approvals here 🙏 |
davidterpay
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove two hashes here.
All CheckTx calls are synchronous from Tendermint, so theres no race condition concerns I missed. If there were race condition concerns, then we should do a single hash and then do a quick check for if things are contained in cache.
This is an automatic backport of pull request #517 done by Mergify.