Fix iterator on empty map #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is actually unreachable code since the loop never exits if it doesn't call its return. Not saying I have a good understanding of if the current version of the code handles empty maps correctly or not though. My guess would be a sentinel element that ensures it always finds an element that has |
This was referenced Feb 7, 2019
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Feb 11, 2019
Summary: Pull Request resolved: #16907 The begin()/end() fix actually doesn't make sense, see my comment on skarupke/flat_hash_map#8 This diff removes it. Reviewed By: ezyang Differential Revision: D13985779 fbshipit-source-id: f08b02c941069e2a4e728e02a19b65dc72f96b41
pearu
pushed a commit
to Quansight/pytorch
that referenced
this pull request
Feb 12, 2019
Summary: Pull Request resolved: pytorch#16907 The begin()/end() fix actually doesn't make sense, see my comment on skarupke/flat_hash_map#8 This diff removes it. Reviewed By: ezyang Differential Revision: D13985779 fbshipit-source-id: f08b02c941069e2a4e728e02a19b65dc72f96b41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.