Skip to content

Commit

Permalink
Revert unneeded fixes in flat_hash_map (pytorch#16907)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: pytorch#16907

The begin()/end() fix actually doesn't make sense, see my comment on skarupke/flat_hash_map#8
This diff removes it.

Reviewed By: ezyang

Differential Revision: D13985779

fbshipit-source-id: f08b02c941069e2a4e728e02a19b65dc72f96b41
  • Loading branch information
smessmer authored and facebook-github-bot committed Feb 11, 2019
1 parent 2d9879c commit c956732
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions c10/util/flat_hash_map.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// Taken from https://github.com/skarupke/flat_hash_map/blob/2c4687431f978f02a3780e24b8b701d22aa32d9c/flat_hash_map.hpp
// with fixes applied:
// - https://github.com/skarupke/flat_hash_map/pull/8
// - https://github.com/skarupke/flat_hash_map/pull/25
// - https://github.com/skarupke/flat_hash_map/pull/26
// - replace size_t with uint64_t to fix it for 32bit
Expand Down Expand Up @@ -522,7 +521,6 @@ class sherwood_v3_table : private EntryAlloc, private Hasher, private Equal
if (it->has_value())
return { it };
}
return end();
}
const_iterator begin() const
{
Expand All @@ -531,7 +529,6 @@ class sherwood_v3_table : private EntryAlloc, private Hasher, private Equal
if (it->has_value())
return { it };
}
return end();
}
const_iterator cbegin() const
{
Expand Down

0 comments on commit c956732

Please sign in to comment.