Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SGX check #1111

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Improve SGX check #1111

merged 4 commits into from
Sep 26, 2024

Conversation

alexgex
Copy link
Contributor

@alexgex alexgex commented Sep 25, 2024

ZeroMQ SGX connection check was added to existing SGX check.

Usage:
$ curl http://YOUR_SKALE_NODE_IP:3009/status/sgx

Old response:
{"data": {"status": 0, "status_name": "CONNECTED", "sgx_wallet_version": "1.9.0"}, "error": null}

New response:
{"data": {"status_zmq": true, "status_https": true, "sgx_wallet_version": "1.9.0"}, "error": null}

No performance related changes were introduced.
No additional tests needed.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.90%. Comparing base (8be5567) to head (39bd051).
Report is 5 commits behind head on v2.8.x.

Files with missing lines Patch % Lines
web/routes/health.py 73.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           v2.8.x    #1111      +/-   ##
==========================================
+ Coverage   81.89%   81.90%   +0.01%     
==========================================
  Files         102      102              
  Lines        6108     6102       -6     
==========================================
- Hits         5002     4998       -4     
+ Misses       1106     1104       -2     
Flag Coverage Δ
81.90% <73.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexgex alexgex linked an issue Sep 26, 2024 that may be closed by this pull request
@alexgex alexgex merged commit 3558fa2 into v2.8.x Sep 26, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ZMQ connection check to watchdog SGX check
3 participants