Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skale health sgx broke after adding ZMQ check to watchdog #792

Closed
OleksanderSalamatov opened this issue Oct 23, 2024 · 1 comment · Fixed by #797 or #798
Closed

skale health sgx broke after adding ZMQ check to watchdog #792

OleksanderSalamatov opened this issue Oct 23, 2024 · 1 comment · Fixed by #797 or #798
Assignees
Labels
bug Something isn't working
Milestone

Comments

@OleksanderSalamatov
Copy link

OleksanderSalamatov commented Oct 23, 2024

Watchdog response to sgx health call has been changed, so skale health sgx command logic shoud be changed to match watchdog response

Node-cli: 2.5.0-beta.0

Old response:
{"data": {"status": 0, "status_name": "CONNECTED", "sgx_wallet_version": "1.9.0"}, "error": null}

New response:
{"data": {"status_zmq": true, "status_https": true, "sgx_wallet_version": "1.9.0"}, "error": null}

Error log:

root@Regression-8:~# skale health sgx
Traceback (most recent call last):
  File "node_cli/main.py", line 122, in <module>
  File "click/core.py", line 1130, in __call__
  File "click/core.py", line 1055, in main
  File "click/core.py", line 1657, in invoke
  File "click/core.py", line 1657, in invoke
  File "click/core.py", line 1404, in invoke
  File "click/core.py", line 760, in invoke
  File "node_cli/cli/health.py", line 59, in sgx
  File "node_cli/core/health.py", line 75, in get_sgx_info
KeyError: 'status_name'
Command failed with following errors:
--------------------------------------------------
'status_name'
--------------------------------------------------
You can find more info in /root/.skale/.skale-cli-log/debug-node-cli.log

Related issue: skalenetwork/skale-admin#1014

@OleksanderSalamatov OleksanderSalamatov added the bug Something isn't working label Oct 23, 2024
@DmytroNazarenko DmytroNazarenko added this to the SKALE 3.1 milestone Oct 24, 2024
@badrogger badrogger linked a pull request Nov 1, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Code Review to Ready For Release Candidate in SKALE Engineering 🚀 Nov 4, 2024
@badrogger badrogger linked a pull request Nov 4, 2024 that will close this issue
@OleksanderSalamatov
Copy link
Author

Verified

skale-admin: 2.8.0-beta.2
node-cli: 2.5.0-beta.3

Logs:

root@Regression-5:~# skale health sgx
┌───────────────────┬──────────────────────────────────────────────────────────────────────┐
│ SGX info          │                                                                      │
├───────────────────┼──────────────────────────────────────────────────────────────────────┤
│ Server URL        │ https://140.82.27.1:1026                                             │
│ SGXWallet Version │ 1.9.0                                                                │
│ Node SGX keyname  │ NEK:fb82dd8f59f4064fabb84fee5dbe79745d7072c2e4918f6c02ffbeac961c6719 │
│ Status HTTPS      │ True                                                                 │
│ Status ZMQ        │ False                                                                │
└───────────────────┴──────────────────────────────────────────────────────────────────────┘

@EvgeniyZZ EvgeniyZZ moved this from Ready For Release Candidate to QA in SKALE Engineering 🚀 Nov 5, 2024
@EvgeniyZZ EvgeniyZZ moved this from QA to Done in SKALE Engineering 🚀 Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants