Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Make a Catch2 test fixture for dataframes #2945

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

johnkerl
Copy link
Member

Issue and/or context: This is an underdiff split beneath #2944 for issue #2407 / [sc-51048].

The intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

While I made a test fixture on #2944 for the new unit-test cases there, I realized the same fixture applied to existing test-cases.

This PR separates out from #2944 the fixture itself, and the keystroke-reduction for existing unit tests. This allows the reviewer to focus solely on the fixture and the refactor without being distracted by any new cases.

Notes for Reviewer:

@johnkerl
Copy link
Member Author

Back into draft while I solve the (unexpected) unit-test failure.

@johnkerl johnkerl marked this pull request as ready for review August 30, 2024 21:03
@johnkerl johnkerl changed the title [c++] Split out a test fixture for dataframes [c++] Make a Catch2 test fixture for dataframes Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.02%. Comparing base (da76951) to head (1bb4f69).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2945      +/-   ##
==========================================
+ Coverage   89.87%   90.02%   +0.15%     
==========================================
  Files          38       38              
  Lines        3999     3999              
==========================================
+ Hits         3594     3600       +6     
+ Misses        405      399       -6     
Flag Coverage Δ
python 90.02% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.02% <ø> (+0.15%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl merged commit 37b6e50 into main Sep 3, 2024
15 checks passed
@johnkerl johnkerl deleted the kerl/dataframe-test-fixture branch September 3, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants