Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Unit-test variant-indexed dataframes #2944

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Aug 30, 2024

Issue and/or context: This is iterative progress for issue #2407 / [sc-51048].

The intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

Leverages #2939 and #2945 to unit-test variant-indexed soma dataframes at the libtiledbsoma level.

No shape-accessor logic is checked on this PR: see #2916.

No resize logic is checked on this PR: see #2917.

Notes for Reviewer:

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.02%. Comparing base (da76951) to head (096094f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2944      +/-   ##
==========================================
+ Coverage   89.87%   90.02%   +0.15%     
==========================================
  Files          38       38              
  Lines        3999     3999              
==========================================
+ Hits         3594     3600       +6     
+ Misses        405      399       -6     
Flag Coverage Δ
python 90.02% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.02% <ø> (+0.15%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl force-pushed the kerl/cpp-variant-indexed-dataframes branch 2 times, most recently from 6bf9cf8 to 2b76537 Compare August 30, 2024 19:54
@johnkerl johnkerl force-pushed the kerl/cpp-variant-indexed-dataframes branch from 2b76537 to fc2e789 Compare August 30, 2024 20:05
@johnkerl johnkerl changed the base branch from main to kerl/dataframe-test-fixture August 30, 2024 20:05
@johnkerl johnkerl force-pushed the kerl/cpp-variant-indexed-dataframes branch 2 times, most recently from db6e299 to f855054 Compare August 30, 2024 21:01
@johnkerl johnkerl force-pushed the kerl/cpp-variant-indexed-dataframes branch from f855054 to b9c5c3c Compare August 30, 2024 21:07
@johnkerl johnkerl changed the title [c++] Unit-test variant-indexed dataframes [WIP] [c++] Unit-test variant-indexed dataframes Aug 30, 2024
@johnkerl johnkerl requested a review from nguyenv August 30, 2024 21:07
@johnkerl johnkerl force-pushed the kerl/cpp-variant-indexed-dataframes branch from b9c5c3c to 2389b53 Compare August 30, 2024 21:10
@johnkerl johnkerl marked this pull request as ready for review August 30, 2024 21:10
@johnkerl johnkerl requested a review from jp-dark August 30, 2024 21:22
@johnkerl johnkerl force-pushed the kerl/cpp-variant-indexed-dataframes branch from 520f37c to db93171 Compare August 30, 2024 21:26
libtiledbsoma/test/unit_soma_dataframe.cc Outdated Show resolved Hide resolved
Base automatically changed from kerl/dataframe-test-fixture to main September 3, 2024 17:39
@johnkerl johnkerl merged commit ded1e42 into main Sep 3, 2024
13 checks passed
@johnkerl johnkerl deleted the kerl/cpp-variant-indexed-dataframes branch September 3, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants