Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rfc2396 parser instead of URI::DEFAULT_PARSER #139

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Use rfc2396 parser instead of URI::DEFAULT_PARSER #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
448b8cd
Use URI::RFC2396_PARSER.escape explicitly
hsbt Aug 8, 2024
0cf6b84
Don't call URI::RFC2396_Parser.new again
hsbt Aug 8, 2024
f782db1
URI::RFC2396_PARSER is not provided at old Ruby version
hsbt Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mustermann/lib/mustermann/ast/translator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def decorator_for(node)

# @return [String] escaped character
# @!visibility private
def escape(char, parser: URI::DEFAULT_PARSER, escape: URI::RFC2396_Parser.new.regexp[:UNSAFE], also_escape: nil)
def escape(char, parser: URI::RFC2396_Parser.new, escape: URI::RFC2396_Parser.new.regexp[:UNSAFE], also_escape: nil)
escape = Regexp.union(also_escape, escape) if also_escape
char.to_s =~ escape ? parser.escape(char, Regexp.union(*escape)) : char
end
Expand Down
2 changes: 1 addition & 1 deletion mustermann/lib/mustermann/pattern.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module Mustermann
# @abstract
class Pattern
include Mustermann
@@uri ||= URI::Parser.new
@@uri ||= URI::RFC2396_Parser.new

# List of supported options.
#
Expand Down
Loading