Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rfc2396 parser instead of URI::DEFAULT_PARSER #139

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Use rfc2396 parser instead of URI::DEFAULT_PARSER #139

merged 3 commits into from
Aug 9, 2024
+2 −2

Conversation

hsbt
Copy link
Contributor

@hsbt hsbt commented Aug 8, 2024

Fixed up #138

URI::DEFAULT_PARSER.escape is obsoleted at next stable release of URI. We should use URI::RFC2396_PARSER.escape instead of URI::DEFAULT_PARSER.

@hsbt hsbt mentioned this pull request Aug 8, 2024
Merged
@dentarg dentarg merged commit 015b05d into sinatra:main Aug 9, 2024
9 checks passed
@dentarg dentarg changed the title Use rfc2396 parser Use rfc2396 parser instead of URI::DEFAULT_PARSER Aug 9, 2024
@dentarg
Copy link
Member

dentarg commented Aug 9, 2024

Released in v3.0.2

@hsbt hsbt deleted the use-rfc2396-parser branch August 19, 2024 01:54
@hsbt hsbt mentioned this pull request Aug 22, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dentarg dentarg dentarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsbt @dentarg