Skip to content

Only use 'main' Parts of speech. Like FLEx. #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
+11 −2
Draft

Only use 'main' Parts of speech. Like FLEx. #2084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76f5a25
Only use 'main' Parts of speech. Like FLEx.
myieye Oct 29, 2025
5f83837
Fix tests that create duplicate parts-of-speech
myieye Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,9 @@ void MoveWs(CoreWritingSystemDefinition ws,

public IAsyncEnumerable<PartOfSpeech> GetPartsOfSpeech()
{
return PartOfSpeechRepository
.AllInstances()
return Cache.LangProject.PartsOfSpeechOA
.ReallyReallyAllPossibilities
.Cast<IPartOfSpeech>()
.OrderBy(p => p.Name.BestAnalysisAlternative.Text)
.ToAsyncEnumerable()
.Select(FromLcmPartOfSpeech);
Expand Down
8 changes: 8 additions & 0 deletions backend/FwLite/FwLiteProjectSync.Tests/SyncTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,14 @@ public async Task DisposeAsync()
{
await _fixture.CrdtApi.DeleteEntry(entry.Id);
}
await foreach (var pos in _fixture.FwDataApi.GetPartsOfSpeech())
{
await _fixture.FwDataApi.DeletePartOfSpeech(pos.Id);
}
foreach (var pos in await _fixture.CrdtApi.GetPartsOfSpeech().ToArrayAsync())
{
await _fixture.CrdtApi.DeletePartOfSpeech(pos.Id);
}
}

public SyncTests(SyncFixture fixture)
Expand Down
Loading