Only use 'main' Parts of speech. Like FLEx.

[myieye]

This excludes e.g. Reversel index parts of speech.

Update: converted to draft, because there should really be test for this before it's merged.

[coderabbitai]

📝 Walkthrough

Walkthrough

GetPartsOfSpeech() now enumerates parts of speech from Cache.LangProject.PartsOfSpeechOA.ReallyReallyAllPossibilities (cast to IPartOfSpeech) instead of PartOfSpeechRepository.AllInstances(); DisposeAsync in tests now deletes PartOfSpeech entries from both FwDataApi and CrdtApi during teardown.

Changes

Cohort / File(s)	Change Summary
Data source change backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs	GetPartsOfSpeech() switched to read from Cache.LangProject.PartsOfSpeechOA.ReallyReallyAllPossibilities (cast to IPartOfSpeech); ordering, async conversion, and mapping preserved
Test teardown cleanup backend/FwLite/FwLiteProjectSync.Tests/SyncTests.cs	DisposeAsync updated to asynchronously delete all PartOfSpeech entries from both FwDataApi and CrdtApi after tests

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10–15 minutes

• Check that the cast to IPartOfSpeech is safe for all items returned by ReallyReallyAllPossibilities.
• Verify ordering and mapping produce identical results to the previous repository-based approach.
• Confirm test teardown deletes the intended items and handles async exceptions cleanly.

Possibly related PRs

• Fix dotnet warnings and suggestions #1951 — touches backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs and PartOfSpeech creation, likely related to PartOfSpeech handling changes.

Suggested reviewers

• hahn-kev

Poem

🐰
Through cached fields I hop and peep,
Gathering speech from where it sleeps.
Tests I tidy, bits I sweep,
Clean traces left — no crumbs to keep. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The pull request title 'Only use 'main' Parts of speech. Like FLEx.' directly relates to the main change in the changeset. The code modification to GetPartsOfSpeech() sources data from Cache.LangProject.PartsOfSpeechOA.ReallyReallyAllPossibilities instead of PartOfSpeechRepository.AllInstances(), which aligns with using only 'main' parts of speech as referenced in the title. The title is concise, clear, and accurately summarizes the primary change.
Description check	✅ Passed	The PR description relates to the changeset by explaining the intent to exclude non-main parts of speech, aligning with the code changes that modify data sourcing for parts of speech.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch only-use-main-parts-of-speech

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

UI unit Tests

  1 files  ±0   45 suites  ±0   19s ⏱️ -9s
111 tests ±0  111 ✅ ±0  0 💤 ±0  0 ❌ ±0 
160 runs  ±0  160 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5f83837. ± Comparison against base commit e7033b0.

♻️ This comment has been updated with latest results.

[argos-ci]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	✅ No changes detected	-	Nov 3, 2025, 2:05 PM

[myieye]

Note, for some reason this change found what I consider to be a bug in our fwdata api (or maybe even LibLcm?).
Without deleting parts of speech after each test run, a duplicate pos started being returned from FwData's GetPartsOfSpeech.
#1931 (comment)

[myieye]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.