fix: stop forcing github runner mode for setup-php - #47
Merged
Conversation
setup-php 2.37.2 treats RUNNER_ENVIRONMENT=self-hosted as self-hosted even when ImageOS is set. Forcing RUNNER=github on runs-on then fails with "Runner set as github in self-hosted environment". Let setup-php auto-detect instead.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Florian Ruppel (fruppel)
approved these changes
Jul 28, 2026
Soner (shyim)
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RUNNER=github/ImageOS/GITHUB_EMULATIONenv override from the Setup PHP stepRUNNER_ENVIRONMENT=self-hostedon runs-on and aborts withRunner set as github in self-hosted environmentTest plan
setup-shopware@maingets past Setup Rufus / Setup PHP