fix: use RUNNER_ENVIRONMENT to keep setup-php on the prebuilt path - #48
Closed
Florian Ruppel (fruppel) wants to merge 1 commit into
Closed
fix: use RUNNER_ENVIRONMENT to keep setup-php on the prebuilt path#48Florian Ruppel (fruppel) wants to merge 1 commit into
Florian Ruppel (fruppel) wants to merge 1 commit into
Conversation
setup-php 2.37 rejects a forced RUNNER=github when it detects a self-hosted environment and exits 1 with "Runner set as github in self-hosted environment". Since our runs-on runners report RUNNER_ENVIRONMENT=self-hosted, every job using this action broke when the pin moved from 2.33.0 to 2.37.2. Override RUNNER_ENVIRONMENT instead. setup-php then resolves the runner to github by itself, so the conflict check no longer triggers and PHP is still installed from the prebuilt package rather than compiled from the ondrej PPA. The env is scoped to this step, so other actions keep seeing the real value. GITHUB_EMULATION was never read by setup-php and is dropped.
Author
|
closed in favor of #47 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup-php 2.37 rejects a forced RUNNER=github when it detects a self-hosted environment and exits 1 with "Runner set as github in self-hosted environment". Since our runs-on runners report RUNNER_ENVIRONMENT=self-hosted, every job using this action broke when the pin moved from 2.33.0 to 2.37.2.
Override RUNNER_ENVIRONMENT instead. setup-php then resolves the runner to github by itself, so the conflict check no longer triggers and PHP is still installed from the prebuilt package rather than compiled from the ondrej PPA. The env is scoped to this step, so other actions keep seeing the real value.
GITHUB_EMULATION was never read by setup-php and is dropped.