Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetadataResolverのテストが不足している #42

Open
16 of 20 tasks
eai04191 opened this issue Jan 16, 2019 · 0 comments
Open
16 of 20 tasks

MetadataResolverのテストが不足している #42

eai04191 opened this issue Jan 16, 2019 · 0 comments
Labels
metadata

Comments

@eai04191
Copy link
Member

eai04191 commented Jan 16, 2019 •
edited
Loading

https://codecov.io/gh/shikorism/tissue/tree/develop/app/MetadataResolver

  • 00.00% - ActivityPubResolver
  • 100.0% - CienResolver
  • 98.00% - DLsiteResolver
  • 100.0% - DeviantArtResolver
  • 100.0% - FC2ContentsResolver
  • 100.0% - FantiaResolver
  • 100.0% - FanzaResolver
  • 100.0% - IwaraResolver
  • 95.00% - KomifloResolver
  • 00.00% - MelonbooksResolver
  • 00.00% - NarouResolver
  • 100.0% - NicoSeigaResolver
  • 100.0% - NijieResolver
  • 100.0% - OGPResolver
  • 00.00% - PatreonResolver
  • 80.65% - PixivResolver
  • 100.0% - PlurkResolver
  • 93.75% - SteamResolver
  • 100.0% - ToranoanaResolver
  • 100.0% - XtubeResolver

Q. これは何のためにあるの
A. Issue立てた時点でめっちゃテストが少なかったのである程度形式的にかけるMetadataResolverのテストくらいはやってしまおうという気持ちがあった
@eai04191 eai04191 changed the title リゾルバのテストが不足している メタデータリゾルバのテストが不足している Jan 16, 2019
shibafu528 added a commit that referenced this issue Jan 17, 2019
@shibafu528
Fix NijieResolverText (#42)
a33a0e5 
とりあえず通るようにしただけ
@eai04191 eai04191 mentioned this issue Mar 1, 2019
Merged
This was referenced Jun 26, 2019
Merged
Merged
@shibafu528 shibafu528 mentioned this issue Aug 3, 2019
Merged
@eai04191 eai04191 mentioned this issue Aug 20, 2019
Merged
@eai04191 eai04191 changed the title メタデータリゾルバのテストが不足している MetadataResolverのテストが不足している Aug 20, 2019
@eai04191 eai04191 mentioned this issue Aug 21, 2019
Merged
@eai04191 eai04191 mentioned this issue Aug 31, 2019
Merged
5 tasks
@shibafu528 shibafu528 mentioned this issue Sep 9, 2019
Merged
This was referenced Sep 11, 2019
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
metadata
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shibafu528 @eai04191