Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToranoanaResolverで、OGP画像の代わりになりそうなサムネ画像を取得する #243

Merged
merged 3 commits into from
Aug 3, 2019

Conversation

shibafu528
Copy link
Member

OGP画像が代替イメージになっててどうしようもないので、商品画像の1枚目を取ってくるようにした。

fix #235

@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #243 into develop will increase coverage by 1.15%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #243      +/-   ##
=============================================
+ Coverage      22.47%   23.63%   +1.15%     
- Complexity       308      309       +1     
=============================================
  Files             59       59              
  Lines           1090     1096       +6     
=============================================
+ Hits             245      259      +14     
+ Misses           845      837       -8
Impacted Files Coverage Δ Complexity Δ
app/MetadataResolver/ToranoanaResolver.php 93.33% <100%> (+93.33%) 4 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb84a1d...b274c6b. Read the comment docs.

@shibafu528 shibafu528 merged commit 3c083a7 into develop Aug 3, 2019
@shibafu528
Copy link
Member Author

refs #42

@shibafu528 shibafu528 deleted the fix/235-tora branch August 3, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

とらのサムネイルが代替画像になっている
1 participant