Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FantiaResolverを更新・テストを追加 #283

Merged

Conversation

eai04191
Copy link
Member

@eai04191 eai04191 commented Sep 11, 2019

APIを見つけたのでAPIを使用するように
タグを追加
テストを追加
@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #283 into develop will increase coverage by 1.62%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #283      +/-   ##
=============================================
+ Coverage      30.01%   31.64%   +1.62%     
  Complexity       289      289              
=============================================
  Files             60       60              
  Lines           1086     1084       -2     
=============================================
+ Hits             326      343      +17     
+ Misses           760      741      -19
Impacted Files Coverage Δ Complexity Δ
app/MetadataResolver/FantiaResolver.php 100% <100%> (+100%) 3 <2> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92847fe...a9a0f3b. Read the comment docs.

@shibafu528 shibafu528 merged commit a20f690 into shikorism:develop Sep 12, 2019
@eai04191 eai04191 deleted the feature/resolver-fantiaResolver-improve branch September 12, 2019 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants