Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix end check in eagle #2723

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jjjjohnson
Copy link

Motivation

After eagel2 target model verify, the accepted tokens might be EOS token, need to check each appended new token. Then free kv cache.

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@merrymercy
Copy link
Contributor

@yukavio can you help review this?

@merrymercy merrymercy changed the title fix end check fix end check in eagle Jan 4, 2025
@zhyncs zhyncs mentioned this pull request Jan 5, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants