Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[willing to PR] optimzation of eagle2 #2720

Open
5 tasks done
jjjjohnson opened this issue Jan 3, 2025 · 2 comments
Open
5 tasks done

[willing to PR] optimzation of eagle2 #2720

jjjjohnson opened this issue Jan 3, 2025 · 2 comments
Assignees

Comments

@jjjjohnson
Copy link
Contributor

jjjjohnson commented Jan 3, 2025

Checklist

  • 1. I have searched related issues but cannot get the expected help.
  • 2. The bug has not been fixed in the latest version.
  • 3. Please note that if the bug-related issue you submitted lacks corresponding environment info and a minimal reproducible demo, it will be challenging for us to reproduce and resolve the issue, reducing the likelihood of receiving feedback.
  • 4. If the issue you raised is not a bug but a question, please raise a discussion at https://github.com/sgl-project/sglang/discussions/new/choose Otherwise, it will be closed.
  • 5. Please use English, otherwise it will be closed.

Describe the bug

The current target model verify implementmation has not check the EOS token, leading to looong output in some cases.

Reproduction

eagle2

Environment

main

@merrymercy
Copy link
Contributor

@jjjjohnson please send the PR!

@jjjjohnson
Copy link
Contributor Author

@merrymercy #2723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants