-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUDA-graph-compatible releasing and resuming KV cache and model weight memory #2630
Open
fzyzcjy
wants to merge
122
commits into
sgl-project:main
Choose a base branch
from
fzyzcjy:feat/memory_saver
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # python/sglang /srt/managers/tokenizer_manager.py
3 tasks
fzyzcjy
changed the title
Allow release memory and later resume (compatible with CUDA graph)
CUDA-graph-compatible releasing and resuming of KV cache and model weight memory
Dec 31, 2024
fzyzcjy
changed the title
CUDA-graph-compatible releasing and resuming of KV cache and model weight memory
CUDA-graph-compatible releasing and resuming KV cache and model weight memory
Dec 31, 2024
fzyzcjy
force-pushed
the
feat/memory_saver
branch
from
December 31, 2024 05:30
9a919d9
to
d9ad0e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2542 and #2583
Outdated Content
The test will fail because it uses
LD_PRELOAD
currently (to intercept and change logic of cudaMalloc and cudaFree). If the general logic looks good, I will further update this PR to handle this part (e.g. try to specify LD_PRELOAD automatically when creating the backend process.)How to execute it
Suppose this branch of SGLang is at
/path/to/sglang
, then inside sglang's docker container, execute the following:Expected results are as follows. x is time, red color is memory consume. The low memory at the center is caused by temporarily release KV cache memory.
What's changed
Though the PR seems large, most are boilerplate.
Core:
with primary_memory_saver.region()
: TokenToKVPool.k_buffers/v_buffers, ModelRunner.model, ReqToTokenPool.req_to_tokenprimary_memory_saver.pause()/.resume()
: Atscheduler.py
, Scheduler.release_gpu_occupation/resume_gpu_occupationOthers:
Checklist