Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiny update scripts to fail fast #2672

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Tiny update scripts to fail fast #2672

merged 2 commits into from
Dec 31, 2024

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Dec 31, 2024

Motivation

set -euxo pipefail is frequently used to allow scripts to e.g. fail fast. I noticed this because when debugging the CI environment locally, a pip install failed but the script continues, causing less intuitive errors later.

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@fzyzcjy fzyzcjy marked this pull request as ready for review December 31, 2024 01:21
@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Dec 31, 2024

Tests of this are in #2630

zhaochenyang20
zhaochenyang20 approved these changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@zhaochenyang20 zhaochenyang20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaochenyang20 zhaochenyang20 merged commit f707470 into sgl-project:main Dec 31, 2024
1 check passed
XiaotongJiang pushed a commit to XiaotongJiang/sglang that referenced this pull request Jan 3, 2025
@fzyzcjy @XiaotongJiang
CI: Update scripts to fail fast (sgl-project#2672)
32bf2fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaochenyang20 zhaochenyang20 zhaochenyang20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fzyzcjy @zhaochenyang20