This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
fix: Adds json schema validator for timezone property
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrzesik
suggested changes
Mar 30, 2022
There was a problem hiding this comment.
thanks @KillDozerX2 - I have only one minor comment, please let me know what do you think
index.js
Outdated
| @@ -121,6 +122,17 @@ function convertCrontabs() { | |||
| class ServerlessLocalCrontabs { | |||
| constructor(serverless, options) { | |||
| this.serverless = serverless; | |||
| if (this.serverless.configSchemaHandler) { | |||
There was a problem hiding this comment.
Sorry for not mentioning it at first - I've just double checked and there can be a situation where the configSchemaHandler is defined, but the defineFunctionEventProperties method is not - let's also check for the existence of this method before trying to call it, okay? It was added in 2.11.0 so let's not break users that are on lower versions: https://github.com/serverless/serverless/blob/main/CHANGELOG.md#2110-2020-11-06
pgrzesik
approved these changes
Mar 30, 2022
pgrzesik
changed the title
timezone property
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fork of #17, @nyoungstudios commits are here as well.