This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
Adds json schema validator to fix issue #14 #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only problem is that I couldn't figure out how to add a custom error message. So, currently it prints out all the valid timezone names if the provided timezone doesn't match the schema. |
|
Rather than add a dependency on |
cedric-r-mycelium
approved these changes
Sep 17, 2021
pgrzesik
suggested changes
Mar 30, 2022
There was a problem hiding this comment.
looks good overall, but requires an adjustment to not. break for older Framework versions cc @KillDozerX2
| @@ -121,6 +122,16 @@ function convertCrontabs() { | |||
| class ServerlessLocalCrontabs { | |||
| constructor(serverless, options) { | |||
| this.serverless = serverless; | |||
|
|
|||
| // Create schema for your properties. For reference use https://github.com/ajv-validator/ajv | |||
| this.serverless.configSchemaHandler.defineFunctionEventProperties('aws', 'schedule', { | |||
There was a problem hiding this comment.
it should check if this.serverless.configSchemaHandler is defined first to avoid breaking for older Framework versions
There was a problem hiding this comment.
I will send PR directly then
|
Close in favor of: #25 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds json schema validator to fix issue #14
Adds moment.js to dependencies
And changes the test-service to use local module for development