Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #126 #127

Merged
merged 1 commit into from
May 15, 2024
Merged

Fix #126 #127

merged 1 commit into from
May 15, 2024

Conversation

kurtismash
Copy link
Collaborator

Moves parsing of event["lifetime"] to a single location within get_csr_info(). Defaults to 30 if not present.

@kurtismash kurtismash linked an issue May 14, 2024 that may be closed by this pull request
Certificates issued outside GitOps process have lifetime hardcoded to 30 days #126
Closed
paulschwarzenberger
paulschwarzenberger approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@paulschwarzenberger paulschwarzenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulschwarzenberger paulschwarzenberger merged commit eb3e8a1 into main May 15, 2024
16 checks passed
@paulschwarzenberger paulschwarzenberger deleted the 126-certificates-issued-outside-gitops-process-have-lifetime-hardcoded-to-30-days branch May 15, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulschwarzenberger paulschwarzenberger paulschwarzenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Certificates issued outside GitOps process have lifetime hardcoded to 30 days
2 participants
@kurtismash @paulschwarzenberger