Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certificates issued outside GitOps process have lifetime hardcoded to 30 days #126

Closed
paulschwarzenberger opened this issue May 14, 2024 · 2 comments · Fixed by #127
Closed

Certificates issued outside GitOps process have lifetime hardcoded to 30 days #126

paulschwarzenberger opened this issue May 14, 2024 · 2 comments · Fixed by #127
Assignees
@kurtismash

Comments

@paulschwarzenberger
Copy link
Contributor

paulschwarzenberger commented May 14, 2024 •
edited
Loading

  • following the Getting Started guide results in a certificate with lifetime 30 days, even though utils/client-cert.py specifies 90 days.
  • requirements.txt location specified in Getting Started is incorrect

reported by @kurtismash
@kurtismash
Copy link
Collaborator

I'll take this!

@kurtismash kurtismash self-assigned this May 14, 2024
kurtismash added a commit that referenced this issue May 14, 2024
@kurtismash
Fix Certificates issued outside GitOps process have lifetime hardcode…
77ad2c0 
…d to 30 days (#126)
@kurtismash kurtismash linked a pull request May 14, 2024 that will close this issue
Fix #126 #127
Merged
@kurtismash
Copy link
Collaborator

The requirements.txt issue was caused by a missing file within a client's implementation, not present in this repository.

paulschwarzenberger pushed a commit that referenced this issue May 15, 2024
@kurtismash
Fix Certificates issued outside GitOps process have lifetime hardcode…
eb3e8a1 
…d to 30 days (#126) (#127)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kurtismash kurtismash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #126 serverless-ca/terraform-aws-ca
2 participants
@kurtismash @paulschwarzenberger