Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mockup(editor): editor datenraum import plugin #3816

Closed
wants to merge 24 commits into from

Conversation

elbotho
Copy link
Member

@elbotho elbotho commented May 22, 2024

  • mocked version without any actual fetches (also works in preview branch now)
  • Search for "Dreisatz" for the mock content to make sense (besides the Lückentext itself unfortunately)
  • content preview on hover
  • make sure click next to the hp5 preview to activate the plugin after searching

demo

https://frontend-git-editor-datenraum-mock-serlo.vercel.app/entity/create/Article/60730

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Jun 12, 2024 5:46pm

Copy link
Contributor

github-actions bot commented May 22, 2024

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 103.95 KB (🟡 +99 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Twenty-two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[...slug] 81.92 KB (🟡 +51 B) 185.87 KB
/___bot_or_not 95.71 KB (🟡 +51 B) 199.66 KB
/___editor_preview 505.34 KB (🟡 +20.55 KB) 609.29 KB
/biologie 157.38 KB (🟡 +51 B) 261.33 KB
/chemie 157.37 KB (🟡 +51 B) 261.32 KB
/content-only/[...slug] 74.35 KB (🟡 +51 B) 178.3 KB
/editor 105.62 KB (🟡 +51 B) 209.57 KB
/entity/create/[type]/[taxonomyId] 506.73 KB (🟡 +20.56 KB) 610.68 KB
/entity/repository/add-revision/[...id] 506.03 KB (🟡 +20.56 KB) 609.98 KB
/entity/repository/compare/[entity_id]/[revision_id] 85.79 KB (🟡 +51 B) 189.74 KB
/informatik 157.38 KB (🟡 +51 B) 261.33 KB
/lerntipps 157.38 KB (🟡 +51 B) 261.33 KB
/license/detail/[id] 57.86 KB (🟡 +51 B) 161.81 KB
/mathe 157.37 KB (🟡 +51 B) 261.32 KB
/nachhaltigkeit 157.38 KB (🟡 +51 B) 261.33 KB
/page/create 506.02 KB (🟡 +20.55 KB) 609.97 KB
/taxonomy/term/[copyOrMove]/batch/[id] 71.52 KB (🟡 +20 B) 175.47 KB
/taxonomy/term/create/[parent_id]/[id] 505.77 KB (🟡 +20.55 KB) 609.72 KB
/taxonomy/term/sort/entities/[id] 93.46 KB (🟡 +20 B) 197.41 KB
/taxonomy/term/update/[id] 505.71 KB (🟡 +20.54 KB) 609.67 KB
/user/profile/[username] 177.2 KB (🟡 +51 B) 281.15 KB
/user/settings 504.67 KB (🟡 +20.54 KB) 608.62 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@Entkenntnis
Copy link
Member

@elbotho You can merge staging into this branch to restore h5p/lumi functionality

@elbotho
Copy link
Member Author

elbotho commented Sep 19, 2024

Closing for a cleaner PR overview. Preview and branch are not affected. Reopen if you want.

@elbotho elbotho closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants