Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: New plugin for integrating media items from Datenraum #3806

Closed
wants to merge 10 commits into from

Conversation

kulla
Copy link
Member

@kulla kulla commented May 21, 2024

What?

This is a plugin to demonstrate how items of the Datenraum can be integrated into the Serlo Editor:

2024-05-21-080248_1906x853_scrot

How you can test it

  • Create a file apps/web/.env.local with the content
DATENRAUM_CLIENT_ID=<clientId>
DATENRAUM_CLIENT_SECRET=<clientSecret>

You can find the secrets when you go to your local infra repository in the terraform secrets file under envs/staging/secret after running make terraform_init. Here you can find a line of the form

kratos_nbp_client = { id = "<clientId>", secret = "<clientSecret>" }

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview May 22, 2024 9:23am

Copy link
Contributor

github-actions bot commented May 21, 2024

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 103.89 KB (🟡 +91 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Twenty-two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[...slug] 82.04 KB (🟡 +49 B) 185.94 KB
/___bot_or_not 95.81 KB (🟡 +49 B) 199.7 KB
/___editor_preview 502.95 KB (🟡 +20.02 KB) 606.85 KB
/biologie 157.46 KB (🟡 +49 B) 261.36 KB
/chemie 157.46 KB (🟡 +49 B) 261.35 KB
/content-only/[...slug] 74.47 KB (🟡 +49 B) 178.37 KB
/editor 104.11 KB (🟡 +49 B) 208.01 KB
/entity/create/[type]/[taxonomyId] 504.22 KB (🟡 +20 KB) 608.11 KB
/entity/repository/add-revision/[...id] 503.49 KB (🟡 +20.01 KB) 607.39 KB
/entity/repository/compare/[entity_id]/[revision_id] 85.91 KB (🟡 +49 B) 189.8 KB
/informatik 157.46 KB (🟡 +49 B) 261.36 KB
/lerntipps 157.46 KB (🟡 +49 B) 261.36 KB
/license/detail/[id] 57.98 KB (🟡 +49 B) 161.88 KB
/mathe 157.46 KB (🟡 +49 B) 261.35 KB
/nachhaltigkeit 157.47 KB (🟡 +49 B) 261.36 KB
/page/create 503.5 KB (🟡 +20.01 KB) 607.4 KB
/taxonomy/term/[copyOrMove]/batch/[id] 71.61 KB (🟡 +18 B) 175.51 KB
/taxonomy/term/create/[parent_id]/[id] 503.28 KB (🟡 +20.01 KB) 607.17 KB
/taxonomy/term/sort/entities/[id] 93.56 KB (🟡 +18 B) 197.46 KB
/taxonomy/term/update/[id] 503.22 KB (🟡 +20.01 KB) 607.12 KB
/user/profile/[username] 176.54 KB (🟡 +49 B) 280.43 KB
/user/settings 502.15 KB (🟡 +20 KB) 606.05 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@kulla
Copy link
Member Author

kulla commented May 24, 2024

superseded by #3816

@kulla kulla closed this May 24, 2024
@kulla kulla deleted the serlo-editor-with-datenraum-plugin branch May 24, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants