Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react] fix Products.test.js failing after PR 667; rename codecov.yml #669

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

realkosty
Copy link
Collaborator

Screenshot 2025-01-29 at 2 03 29 PM

although I think we should make npm test --coverage pass regardless if tests succeed or fail

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
empower ⬜️ Ignored (Inspect) Jan 29, 2025 10:05pm

Copy link

codecov bot commented Jan 29, 2025

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.13%. Comparing base (9cea64b) to head (233b0d2).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #669   +/-   ##
=======================================
  Coverage   34.13%   34.13%           
=======================================
  Files          37       37           
  Lines         920      920           
  Branches      111      111           
=======================================
  Hits          314      314           
  Misses        589      589           
  Partials       17       17           
Flag Coverage Δ
api 6.59% <ø> (ø)
frontend 54.75% <ø> (ø)
Components Coverage Δ
checkout_module 6.59% <ø> (ø)
product_component 56.41% <ø> (ø)

@realkosty
Copy link
Collaborator Author

self-approving

@realkosty realkosty merged commit 312b491 into master Jan 29, 2025
20 checks passed
@realkosty realkosty deleted the react-fix-tests2 branch January 29, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant